Skip to content

Fix Windows NTP server concatenation#185

Merged
ader1990 merged 1 commit intocloudbase:masterfrom
jcmoore3:fix-windows-ntp-server
Apr 17, 2026
Merged

Fix Windows NTP server concatenation#185
ader1990 merged 1 commit intocloudbase:masterfrom
jcmoore3:fix-windows-ntp-server

Conversation

@jcmoore3
Copy link
Copy Markdown
Contributor

Ensure the list of NTP servers is space delimited

@ader1990
Copy link
Copy Markdown
Member

Hello, thank you for the proposed fix.

Adding here the reason for this change - according to the
https://learn.microsoft.com/en-us/windows-server/networking/windows-time-service/windows-time-service-tools-and-settings?tabs=config#command-line-parameters-for-w32time:

/manualpeerlist:<peers>: Sets the manual peer list to <peers>, which is a space-delimited list of Domain Name System (DNS) or IP addresses. When you specify multiple peers, this option must be enclosed in quotation marks.

@ader1990
Copy link
Copy Markdown
Member

We will be soon switching to Github PRs (currently still using opendev) and one of the requirements will be the DCO with signed commits. Can you please add the link to the documentation in your commit and sign the commit?

Thanks.

@ader1990
Copy link
Copy Markdown
Member

Also, if you can please rebase the PR so that I can trigger the workflows runs. Thank you.

@jcmoore3 jcmoore3 force-pushed the fix-windows-ntp-server branch 2 times, most recently from aa5f3f6 to a6e1ce9 Compare March 30, 2026 19:14
@ader1990
Copy link
Copy Markdown
Member

Hello, can you please rebase for the tests to pass and also sign off the commit as per DCO https://github.com/cloudbase/cloudbase-init/blob/master/DCO? Thanks.

@ader1990
Copy link
Copy Markdown
Member

Hello, you can do something like git commit -s --amend --reset-author for the signing part. The current state of this PR branch has an extra commit used for rebase - if you can please remove that as well.

@jcmoore3 jcmoore3 force-pushed the fix-windows-ntp-server branch from 56c2237 to 30a699d Compare April 16, 2026 21:18
From Microsoft's documentation for w32time:
https://learn.microsoft.com/en-us/windows-server/networking/windows-time-service/windows-time-service-tools-and-settings?tabs=config#command-line-parameters-for-w32time

/manualpeerlist:<peers>: Sets the manual peer list to <peers>,
which is a space-delimited list of Domain Name System (DNS)
or IP addresses. When you specify multiple peers, this option
must be enclosed in quotation marks.

Signed-off-by: Curt Moore <curt.moore@garmin.com>
@jcmoore3 jcmoore3 force-pushed the fix-windows-ntp-server branch from 30a699d to 4b2068b Compare April 16, 2026 21:36
@ader1990
Copy link
Copy Markdown
Member

Looks good to me, thank you for the fix.

@ader1990 ader1990 merged commit a22ac6c into cloudbase:master Apr 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants